Skip to content

fix: keep Windows microphone guidance Windows-only#1032

Merged
cjpais merged 3 commits intocjpais:mainfrom
ferologics:fix/windows-mic-permission-guidance
Mar 15, 2026
Merged

fix: keep Windows microphone guidance Windows-only#1032
cjpais merged 3 commits intocjpais:mainfrom
ferologics:fix/windows-mic-permission-guidance

Conversation

@ferologics
Copy link
Copy Markdown
Contributor

Before Submitting This PR

Please confirm you have done the following:

If this is a feature or change that was previously closed/rejected:

  • I have explained in the description below why this should be reconsidered
  • I have gathered community feedback (link to discussion below)

Human Written Description

I noticed the microphone error normalization added in #945 was turning generic permission-denied errors into Windows-specific remediation text on every platform. This keeps the Windows guidance on Windows, but preserves the original error on macOS/Linux so users are not sent to the wrong OS settings.

Related Issues/Discussions

Follow-up to #945

Fixes #: n/a (no dedicated issue)
Discussion: none

Community Feedback

None yet.

Testing

  • cd src-tauri && cargo test --lib

Screenshots/Videos (if applicable)

N/A

AI Assistance

  • No AI was used in this PR
  • AI was used (please describe below)

If AI was used:

  • Tools used: Pi coding agent
  • How extensively: Used to inspect the existing bug, make the small Rust change, add unit tests, run checks, and draft this PR body.

@ferologics ferologics force-pushed the fix/windows-mic-permission-guidance branch from 1b13a29 to 5eace9b Compare March 13, 2026 15:14
@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Mar 14, 2026

@ferologics mind giving this a review? I think it's best if we move away from hard coded strings and errors if we can and when we can.

@github-actions
Copy link
Copy Markdown

🧪 Test Build Ready

Build artifacts for PR #1032 are available for testing.

Download artifacts from workflow run

Artifacts expire after 30 days.

@cjpais cjpais merged commit a6e8fc8 into cjpais:main Mar 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants