Skip to content

fix(nix): update hash#1016

Closed
CaptainSpof wants to merge 1 commit intocjpais:mainfrom
CaptainSpof:main
Closed

fix(nix): update hash#1016
CaptainSpof wants to merge 1 commit intocjpais:mainfrom
CaptainSpof:main

Conversation

@CaptainSpof
Copy link
Copy Markdown

Before Submitting This PR

Please confirm you have done the following:

If this is a feature or change that was previously closed/rejected:

  • I have explained in the description below why this should be reconsidered
  • I have gathered community feedback (link to discussion below)

Human Written Description

This PR fixes build failure when using nix by updating an out of date hash.

Related Issues/Discussions

Fixes #
Discussion:

It is related to #948 that introduced a CI that checks the hashes alongside a script to update said hashes.

Community Feedback

Testing

I ran the script update-nix-hashes.sh locally, then built and ran handy on my NixOS setup.

Screenshots/Videos (if applicable)

AI Assistance

  • No AI was used in this PR
  • AI was used (please describe below)

If AI was used:

  • Tools used:
  • How extensively:

@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Mar 12, 2026

Im not sure how all this nixos stuff is ever supposed to work if it's not integrated into the release cycle itself. These PR's are a mess. The hash will continue to change...

@CaptainSpof
Copy link
Copy Markdown
Author

Pinging @xilec who made the original PR.

From what I understood of the PR, a CI job checks that the hashes are valid, if not it only tells you to update the hashes via the provided script. So I think you're correct, there will be manual PR made every time the hashes change.

That being said (and someone correct me if I am wrong) a CI job could potentially handle updating the hashes

@xilec
Copy link
Copy Markdown
Contributor

xilec commented Mar 12, 2026

@CaptainSpof As I understand, the CI job doesn't have permission to commit to fork repositories by default.

@cjpais Nix hashes will change when dependencies are updated, but it shouldn't be a problem anymore. In PR #1021 I reworked the Nix package build so that keeping it working requires no Nix knowledge — in most cases dependency updates are handled automatically via a postinstall hook, or by running a single script as shown in the CI output.

@cjpais
Copy link
Copy Markdown
Owner

cjpais commented Mar 13, 2026

Okay I think we can close this in favor of #1021. I will try to follow up more there tomorrow

@cjpais cjpais closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants