Skip to content

Commit 70346d0

Browse files
authored
Make udaf_default_* display/schema name helpers non-generic (214 KB smaller binary) (apache#24728)
## Which issue does this PR close? - Part of apache#24727 ## Rationale for this change The default `udaf_default_*` display / schema name helpers in `datafusion/expr/src/udaf.rs` are instantiated for each UDAF ## What changes are included in this PR? 1. Move the default implementations of the five display / schema name methods into non-generic builder structs so each body is compiled only once 2. Update the `AggregateUDFImpl` default methods to use the builders 3. Mark existing functions as deprecated 4. Add a doc example ## Code size Measured per the methodology in apache#24727, at merge base d66f4b9 and on this branch (39d0e53). `cargo llvm-lines --release -p datafusion-functions-aggregate --lib` (29 `AggregateUDFImpl` implementations): | | main (d66f4b9) | this branch | change | | ------------------------------ | ---------------------- | ----------------- | ---------------------- | | `udaf_default_*` display/schema name helpers | 212,048 IR lines (2,755 functions) | 0 | **-212,048 (-100%)** | | Crate total | 2,112,337 IR lines (39,704 copies) | 1,900,949 IR lines (36,936 copies) | **-211,388 (-10.0%)** | `cargo llvm-lines --release -p datafusion-expr --lib` (the builder bodies now compile here exactly once): | | main (d66f4b9) | this branch | change | | ----------- | ------------------ | ------------------ | ------------------- | | Crate total | 1,265,863 IR lines (26,406 copies) | 1,229,636 IR lines (25,925 copies) | **-36,227 (-2.9%)** | `cargo build --release --bin datafusion-cli`: | | main (d66f4b9) | this branch (39d0e53) | change | | ----------- | ----------------- | --------------------------- | --------------------------- | | Binary size | 81,580,368 bytes | 81,365,536 bytes | **-214,832 bytes (-0.26%)** | ## Are these changes tested? Covered by existing tests ## Are there any user-facing changes? Yes, but not breaking:
1 parent 9b05156 commit 70346d0

2 files changed

Lines changed: 457 additions & 200 deletions

File tree

‎datafusion/expr/src/lib.rs‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,14 @@ pub use sqlparser;
136136
pub use table_source::{TableProviderFilterPushDown, TableSource, TableType};
137137
pub use udaf::{
138138
AggregateUDF, AggregateUDFImpl, ReversedUDAF, SetMonotonicity, StatisticsArgs,
139-
udaf_default_display_name, udaf_default_human_display, udaf_default_return_field,
140-
udaf_default_schema_name, udaf_default_window_function_display_name,
141-
udaf_default_window_function_schema_name,
139+
UdafDisplayNameBuilder, UdafHumanDisplayBuilder, UdafSchemaNameBuilder,
140+
UdafWindowFunctionDisplayNameBuilder, UdafWindowFunctionSchemaNameBuilder,
141+
udaf_default_return_field,
142+
};
143+
#[expect(deprecated)]
144+
pub use udaf::{
145+
udaf_default_display_name, udaf_default_human_display, udaf_default_schema_name,
146+
udaf_default_window_function_display_name, udaf_default_window_function_schema_name,
142147
};
143148
pub use udf::{
144149
ReturnFieldArgs, ScalarFunctionArgs, ScalarUDF, ScalarUDFImpl, StructFieldMapping,

0 commit comments

Comments
 (0)