Skip to content

Support Debian Trixie in powershell Molecule scenario, fix bug in csharp Molecule scenario#72

Merged
jsf9k merged 5 commits intodevelopfrom
improvement/support-debian-trixie
Sep 3, 2025
Merged

Support Debian Trixie in powershell Molecule scenario, fix bug in csharp Molecule scenario#72
jsf9k merged 5 commits intodevelopfrom
improvement/support-debian-trixie

Conversation

@jsf9k
Copy link
Copy Markdown
Member

@jsf9k jsf9k commented Sep 3, 2025

🗣 Description

This pull request:

  • Adds a workaround to support Debian Trixie in this Ansible role's powershell Molecule scenario
  • Fixes a bug that was causing the csharp Molecule scenario tests to fail for Kali

💭 Motivation and context

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

Debian Trixie has libicu76, but the deb package generated for
PowerShell/PowerShell only supports libicu74 for now.  This is the
case even though PowerShell/PowerShell functions fine with libicu76.
See PowerShell/PowerShell#25865 for more information.

Until a new release is created, we use Debian's equivs package to
install a dummy dependency for libicu74, which is sufficient to
install PowerShell/PowerShell.  When run, PowerShell/PowerShell will
use the libicu76 dependency installed from the official Debian Trixie
package repository.
@jsf9k jsf9k self-assigned this Sep 3, 2025
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number github-actions Pull requests that update GitHub Actions code labels Sep 3, 2025
When one installs mono-complete on Kali, apt now actually installs
mono-devel.
@jsf9k jsf9k marked this pull request as ready for review September 3, 2025 18:06
@jsf9k jsf9k enabled auto-merge September 3, 2025 18:06
@jsf9k jsf9k requested a review from a team September 3, 2025 18:06
Comment thread tasks/install_powershell_Debian.yml
This package has always just been there, but by explicitly installing
it we ensure that is the case.  Otherwise, PowerShell could get
installed on Trixie with only the libicu74 dummy/equivs package.

The ICU library is fairly fundamental, which probably explains why it
was always "just there":
https://unicode-org.github.io/icu/userguide/icu/

Co-authored-by: Nick M <[email protected]>
@jsf9k jsf9k requested a review from mcdonnnj September 3, 2025 18:47
@jsf9k jsf9k changed the title Support Debian Trixie in powershell scenario Support Debian Trixie in powershell Molecule scenario, fix bug in csharp Molecule scenario Sep 3, 2025
@jsf9k jsf9k merged commit 965a9c8 into develop Sep 3, 2025
127 checks passed
@jsf9k jsf9k deleted the improvement/support-debian-trixie branch September 3, 2025 19:08
jsf9k added a commit that referenced this pull request Mar 12, 2026
This also allows us to get rid of the equivs jazz added in #72, since
the latest release (7.5.5) includes PowerShell/PowerShell#26792.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants