Update to fs2 3.0, cats-effect 3.0#232
Merged
BenFradet merged 2 commits intocirce:masterfrom May 5, 2021
Merged
Conversation
Member
|
👍 from me. |
Contributor
|
Pity we can't get rid of diff --git a/src/main/scala/io/circe/fs2/package.scala b/src/main/scala/io/circe/fs2/package.scala
index 5b4ee55..56ff443 100644
--- a/src/main/scala/io/circe/fs2/package.scala
+++ b/src/main/scala/io/circe/fs2/package.scala
@@ -5,6 +5,7 @@ import cats.effect.Sync
import io.circe.jawn.CirceSupportParser
import org.typelevel.jawn.{ AsyncParser, ParseException }
import scala.collection.Seq
+import _root_.fs2.RaiseThrowable
package object fs2 {
private[this] val supportParser: CirceSupportParser = new CirceSupportParser(None, true)
@@ -39,7 +40,7 @@ package object fs2 {
final def byteParser[F[_]: Sync](mode: AsyncParser.Mode): Pipe[F, Byte, Json] = _.chunks.through(byteParserC(mode))
- final def decoder[F[_]: Sync, A](implicit decode: Decoder[A]): Pipe[F, Json, A] =
+ final def decoder[F[_]: RaiseThrowable, A](implicit decode: Decoder[A]): Pipe[F, Json, A] =
_.flatMap { json =>
decode(json.hcursor) match {
case Left(df) => Stream.raiseError(df)
|
kubukoz
approved these changes
Apr 3, 2021
Collaborator
|
@arixmkii can you rebase and we'll merge? |
Contributor
Author
|
@BenFradet rebased to latest. |
Contributor
Author
|
There is fs2 version 3.0.2 already released and I forgot to add it in the moment of rebase. Should I add it or keep as is? |
Contributor
|
3.0.1 is fine, I think |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 7 7
======================================
Misses 7 7
Continue to review full report at Codecov.
|
Contributor
|
wohoo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206
There were no APIs with incompatible signatures (in explicit parts) used, so, I only patched Spec to revive
unsafeRunSync().Additionally bumped
sbt, because 1.4.8 causes issues at least on my machine.