Skip to content

Use almost all the Prism styles#2355

Merged
ajbura merged 1 commit intocinnyapp:devfrom
RGBCube:change-rgbcube-kqxzvsoxunlt
Jun 29, 2025
Merged

Use almost all the Prism styles#2355
ajbura merged 1 commit intocinnyapp:devfrom
RGBCube:change-rgbcube-kqxzvsoxunlt

Conversation

@RGBCube
Copy link
Copy Markdown
Contributor

@RGBCube RGBCube commented Jun 8, 2025 •
edited
Loading

Description

Uses all working Prism styles for more codeblock highlighting.

I've verified that the current styles all load and highlight, but the ones I've commented out either depend on others or are broken. Should I remove those?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [no need] I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 8, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@RGBCube
Copy link
Copy Markdown
Contributor Author

RGBCube commented Jun 8, 2025

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Jun 8, 2025
@ajbura
@RGBCube has signed the CLA in cinnyapp/cinny#2355
dc3c6b9
@RGBCube
Copy link
Copy Markdown
Contributor Author

RGBCube commented Jun 8, 2025

Fixes #1589

ajbura
ajbura reviewed Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it is ready to review?

Comment thread src/app/plugins/react-prism/ReactPrism.tsx Outdated
Comment on lines +295 to +296
// TODO: Find out why some work such as t4 while bison fails by
// saying 'ruby is undefined', while we import it before it.
Copy link
Copy Markdown
Member

@ajbura ajbura Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, are you still working on it?

Copy link
Copy Markdown
Contributor Author

@RGBCube RGBCube Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to not include them, it seems some are actually just broken. I'll just remove the "find out" comment & leave the note there

Copy link
Copy Markdown
Contributor Author

@RGBCube RGBCube Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just edited, should be ready to merge/review now

@RGBCube RGBCube force-pushed the change-rgbcube-kqxzvsoxunlt branch from becc5f6 to f665ad9 Compare June 27, 2025 16:25
@ajbura ajbura self-requested a review June 27, 2025 16:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 27, 2025 •
edited
Loading

Preview: https://2355--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

ajbura
ajbura requested changes Jun 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like your last commit unknowingly alter all single quotes with double quotes.

@RGBCube
Copy link
Copy Markdown
Contributor Author

RGBCube commented Jun 28, 2025

Oops, fixing asap

@RGBCube RGBCube force-pushed the change-rgbcube-kqxzvsoxunlt branch from f665ad9 to ce92c9c Compare June 29, 2025 08:34
@RGBCube
Copy link
Copy Markdown
Contributor Author

RGBCube commented Jun 29, 2025

Should be done now

@ajbura ajbura merged commit ebe5beb into cinnyapp:dev Jun 29, 2025
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ajbura ajbura ajbura approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RGBCube @ajbura