Add basic m.thread support#1349
Conversation
|
Preview: https://1349--pr-cinny.netlify.app |
| if (replyDraft.relatesTo?.rel_type === "m.thread") { | ||
| content['m.relates_to'].event_id = replyDraft.relatesTo.event_id; | ||
| content['m.relates_to'].rel_type = "m.thread"; | ||
| } |
There was a problem hiding this comment.
As we do not support thread in cinny we should also add "is_falling_back": true as we are replying to a message which is part of thread compare to sending a message in thread with client that support them.
There was a problem hiding this comment.
There was a problem hiding this comment.
It's the other way around. If we sent "is_falling_back": true, the message would be interpreted as posted to the thread directly with m.in_reply_to being set only for fallback purposes.
There was a problem hiding this comment.
This time I explicitly set is_falling_back to false. I think it's saner considering we're making a normal reply from Cinny's perspective.
|
Is any help needed here? I can try to contribute if you think I could help :) |
|
Can the reviewers with write access please look at this? This has been open for quite some time and threads are a noticeable missing feature |
|
I added threaded reply indicators inspired by element-x. Should resolve #1871. |
|
i'm not an approver but i've briefly tested the netlify deployment of this PR and it looks fantastic, i'm very eager to see this merged. seems like the quoted message doesn't get truncated with elipses (...) properly, and runs off the right hand side of the screen.
|
|
same messages in stable cinny:
|
|
@williamkray looks like I broke it again. Thanks for the report. |
|
looks good after the fix! |
ajbura
left a comment
ajbura
left a comment
There was a problem hiding this comment.
Thanks for the PR, it looks great to me.
Could you please mark the PR as ready for review.
|
I converted rem units to equivalent |
5 participants
Description
Adds basic
m.threadsupport as described in MSC3440.Support in this case means that replying to a threaded message will place the reply in the thread in clients that support them.
Partially fixes #257
Type of change
Checklist: