Conversation
brb
force-pushed
the
pr/brb/ci-bpf-xdp
branch
4 times, most recently
from
2f049a8 to
c013fd4
Compare
brb
force-pushed
the
pr/brb/ci-bpf-xdp
branch
from
c013fd4 to
01e00d6
Compare
This is going to be used to test --filter-track-{xdp,tc}, and later on
--filter-track-bpf-helpers.
This commit adds the compiled BPF progs, to reduce the runtime
dependency burden for the GH workflows (no need to install Clang).
Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/ci-bpf-xdp
branch
2 times, most recently
from
621dd8a to
68bca0b
Compare
tklauser
reviewed
Jan 31, 2025
So that we can check whether pwru can start when there are the progs loaded. Later on, we will extend the prog to call BPF helpers and do tail jumps. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/ci-bpf-xdp
branch
from
68bca0b to
3638c0b
Compare
tklauser
reviewed
Jan 31, 2025
| - name: Build test-app | ||
| run: | | ||
| cd test-app | ||
| go build . |
Member
There was a problem hiding this comment.
I wonder whether we should run go generate here to generate bpf_x86_bpfel.* rather than adding these generated files to the repo. But then again I'm not sure what the standard practice is regarding these generated files for ebpf-go programs.
Member
Author
There was a problem hiding this comment.
Yeah, I was considering that, but then from the commit msg:
This commit adds the compiled BPF progs, to reduce the runtime dependency burden for the GH workflows (no need to install Clang)
I am expecting that prog to change very rarely, so the no need to install Clang for each PR outweighs the convenience.
Member
There was a problem hiding this comment.
Should have read the commit message 😬 all good then
tklauser
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #484