Merged
Conversation
Asphaltt
force-pushed
the
feat/output-tcpflags
branch
from
84e15d5 to
c14460f
Compare
brb
reviewed
Jan 15, 2025
Member
brb
left a comment
brb
left a comment
There was a problem hiding this comment.
I like it, thanks! We are running out of screen space in the default output, maybe you could enable printing the tcp flags with --output-tcp-flags?
It will be helpful to check receiving a RST packet when fail to run `telnet`. ```bash $ sudo ./pwru --output-tcp-flags --filter-func '.*tcp.*' tcp and host 192.168.241.1 and port 8080 2024/12/06 14:30:17 Attaching kprobes (via kprobe-multi)... 146 / 146 [------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s 2024/12/06 14:30:17 Attached (ignored 0) 2024/12/06 14:30:17 Listening for events.. SKB CPU PROCESS NETNS MARK/x IFACE PROTO MTU LEN __sk_buff->cb[] TUPLE FUNC 0xffff91e7c90a98e8 6 <empty>:0 4026531840 0 ens33:2 0x0800 1500 74 [0x00000000,0x00000000,0x00000000,0x00000000,0x00000000] 192.168.241.133:32956->192.168.241.1:8080(tcp:SYN) tcp_wfree 0xffff91e7cf0a3e00 6 <empty>:0 4026531840 0 ens33:2 0x0800 1500 46 [0x00000000,0x00000000,0x00000014,0x00000006,0x00060001] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp4_gro_receive 0xffff91e7cf0a3e00 6 <empty>:0 4026531840 0 ens33:2 0x0800 1500 46 [0x00000000,0x00000000,0x00000014,0x00000006,0x00060001] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_gro_receive 0xffff91e7cf0a3e00 6 <empty>:0 4026531840 0 ens33:2 0x0800 1500 40 [0x00000000,0x00000000,0x00000000,0x00000000,0x00060001] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_v4_early_demux 0xffff91e7cf0a3e00 6 <empty>:0 4026531840 0 ens33:2 0x0800 65536 20 [0x00000000,0x00000000,0x00000000,0x00000000,0x00060001] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_v4_rcv 0xffff91e7cf0a3e00 6 <empty>:0 4026531840 0 ens33:2 0x0800 65536 20 [0x00000000,0x00000000,0x00000000,0x00000000,0x00060001] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_filter 0xffff91e7cf0a3e00 6 <empty>:0 4026531840 0 ens33:2 0x0800 65536 20 [0x00000000,0x00000000,0x00000000,0x00000000,0x00060001] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_v4_fill_cb 0xffff91e7cf0a3e00 6 <empty>:0 0 0 0 0x0800 65536 20 [0x00000000,0x04000014,0x80E6EBB0,0x00000000,0x00000002] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_v4_do_rcv 0xffff91e7cf0a3e00 6 <empty>:0 0 0 0 0x0800 65536 20 [0x00000000,0x04000014,0x80E6EBB0,0x00000000,0x00000002] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_rcv_state_process 0xffff91e7cf0a3e00 6 <empty>:0 0 0 0 0x0800 65536 20 [0x00000000,0x04000014,0x80E6EBB0,0x00000000,0x00000002] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_rcv_synsent_state_process 0xffff91e7cf0a3e00 6 <empty>:0 0 0 0 0x0800 65536 20 [0x00000000,0x04000014,0x80E6EBB0,0x00000000,0x00000002] 192.168.241.1:8080->192.168.241.133:32956(tcp:RST|ACK) tcp_reset ^C2024/12/06 14:30:22 Received signal, exiting program.. 2024/12/06 14:30:22 Detaching kprobes... 4 / 4 [---------------------------------------------------------------------------------------------------------------------------------------] 100.00% 22 p/s ``` Signed-off-by: Leon Hwang <[email protected]>
Asphaltt
force-pushed
the
feat/output-tcpflags
branch
from
c14460f to
e5c7181
Compare
Member
|
Agree with --output-tcp-flags, also raise my concern about " running out of screen space" 😿 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be helpful to check receiving a RST packet when fail to run
telnet.