Skip to content

Comments

Add support for printing skb_shared_info#364

Merged
brb merged 1 commit intocilium:mainfrom
YutaroHayakawa:shinfo
Apr 29, 2024
Merged

Add support for printing skb_shared_info#364
brb merged 1 commit intocilium:mainfrom
YutaroHayakawa:shinfo

Conversation

@YutaroHayakawa
Copy link
Member

@YutaroHayakawa YutaroHayakawa commented Apr 25, 2024 •
edited
Loading

struct skb_shared_info is a structure that primarily used by GSO/GRO to store metadata. It is useful to track the behavior of the segmentation offload behavior.

Example output:

0xffff985c8384bb00      5 [irq/215-iwlwifi:queue_7:458]        validate_xmit_skb
(struct skb_shared_info){
 .gso_segs = (short unsigned int)1,
 .gso_type = (unsigned int)1,
 .dataref = (atomic_t){
  .counter = (int)65538,
 },
}

@YutaroHayakawa YutaroHayakawa requested a review from a team as a code owner April 25, 2024 15:25
@YutaroHayakawa YutaroHayakawa requested review from jschwinger233 and removed request for a team April 25, 2024 15:25
@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Apr 25, 2024

Oops, CI is failing. Let me check tomorrow.

@jschwinger233
Copy link
Member

jschwinger233 commented Apr 26, 2024

CI failed because pwru --output-tuple 'dst host 1.0.0.1 and port 8080' gave unexpected output, you can check the Fetch artifacts section in https://github.com/cilium/pwru/actions/runs/8843693323/job/24284322225?pr=364:

--- /tmp/pwru-basic-ipv4.log ---
               SKB    CPU          PROCESS                     FUNC
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]           __ip_local_out :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]             nf_hook_slow :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]    ipv4_conntrack_defrag :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]      selinux_ipv4_output :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]     ipv4_conntrack_local :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]          nf_conntrack_in :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]  nf_conntrack_tcp_packet :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]       ip_vs_local_reply4 :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]     ip_vs_local_request4 :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]                kfree_skb :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]   skb_release_head_state :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]                tcp_wfree :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]         skb_release_data :17517->:45634()
0xffff9b82b4db44e0      6 [/usr/bin/curl:727]             kfree_skbmem :17517->:45634()

It is expected to see 1.0.0.1:8080.

@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Apr 26, 2024

Ah, I see... Seems like I messed up the event layout. Let me see...

@jschwinger233
Copy link
Member

jschwinger233 commented Apr 26, 2024

(BTW thanks for helping even when you are on PTO

@YutaroHayakawa
Add support for printing skb_shared_info
c8cce9b 
It is useful to track the behavior of the segmentation offload behavior.

Signed-off-by: Yutaro Hayakawa <[email protected]>
@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Apr 26, 2024 •
edited
Loading

This is my hobby project to retire ipftrace2 😄

The goal is implement all feature parities to pwru and archive it.

@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Apr 26, 2024

Ok, CI is fixed

@brb
Copy link
Member

brb commented Apr 29, 2024

Thanks!

@brb brb merged commit c076a4c into cilium:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YutaroHayakawa @jschwinger233 @brb