Skip to content

Comments

Add LoongArch support#337

Merged
jschwinger233 merged 3 commits intocilium:mainfrom
chenhengqi:dev-0302
Feb 28, 2025
Merged

Add LoongArch support#337
jschwinger233 merged 3 commits intocilium:mainfrom
chenhengqi:dev-0302

Conversation

@chenhengqi
Copy link
Contributor

No description provided.

@chenhengqi chenhengqi requested a review from a team as a code owner March 2, 2024 09:02
@chenhengqi chenhengqi requested review from jschwinger233 and removed request for a team March 2, 2024 09:02
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you also want to generate loongarch binary on release? (then you can download pre-compiled pwru from https://github.com/cilium/pwru/releases/) If so, some minor changes on Makefile (local-release) shall be made.

@brb
Copy link
Member

brb commented Jan 15, 2025

@chenhengqi 👋 Bump

@brb brb marked this pull request as draft January 15, 2025 10:50
Update libbpf to its latest release, which contains
support for LoongArch.

Signed-off-by: Hengqi Chen <[email protected]>
The vmlinux.h is generated on Linux v6.7. This enables
building kprobe_pwru on LoongArch.

Signed-off-by: Hengqi Chen <[email protected]>
With this change, we can now build pwru on LoongArch using:
    $ make TARGET_GOARCH=loong64 GOARCH=loong64 LIBPCAP_ARCH=

Signed-off-by: Hengqi Chen <[email protected]>
@chenhengqi
Copy link
Contributor Author

Thanks! Do you also want to generate loongarch binary on release? (then you can download pre-compiled pwru from https://github.com/cilium/pwru/releases/) If so, some minor changes on Makefile (local-release) shall be made.

Sorry for the long delay. I am inclined to keep it as it is for now. Thanks.

@chenhengqi chenhengqi marked this pull request as ready for review February 27, 2025 11:14
@chenhengqi
Copy link
Contributor Author

@brb Just rebase and mark it as ready for review. Thanks.

Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, my only concern is neither I or CI don't have Loong env to test it. @chenhengqi Have you run the pwru compiled from this PR?

@chenhengqi
Copy link
Contributor Author

Yep, I run it on my 3A5000 machine.

@jschwinger233 jschwinger233 merged commit 63396c8 into cilium:main Feb 28, 2025
8 checks passed
@brb
Copy link
Member

brb commented Mar 28, 2025

@chenhengqi Thanks for the PR. Would you mind providing a GH runner to that we can test pwru on it? Happy to help with setup.

@chenhengqi
Copy link
Contributor Author

OK, just add to my TODO list.

@brb brb mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants