Temporarily fix the EADDRNOTAVAIL when loading#302
Merged
Conversation
[1] changed the kprobe loading behavior in a way that if we try to attach a kprobe to a function with a duplicate name, then it will fail with EADDRNOTAVAIL [2]. As pwru loads kprobes by using function symbol names, we are prone to this behavior change. Fix the loading problem by ignoring EADDRNOTAVAIL w/ the kprobe backend. Also, instruct users when the kprobe.multi backend is used. The proper fix is to use function addrs instead of syms when loading. This is what Leon H. is working on. [1]: https://lore.kernel.org/all/[email protected]/. [2]: https://elixir.bootlin.com/linux/v6.6/source/kernel/trace/trace_kprobe.c#L884 Signed-off-by: Leon Hwang <[email protected]> Signed-off-by: Martynas Pumputis <[email protected]>
To fix the loading issue on the bpf-next kernel [1]. [1]: #284 Signed-off-by: Martynas Pumputis <[email protected]>
jschwinger233
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit msgs.
Related #284.
cc @Asphaltt