Conversation
Member
Author
|
@brb Please read the 1st commit's message, I'm not sure it's what we want. The 1st commit actually changes the meaning of I did it because I found it sometimes misleading, for example, For those who aren't fimiliar with skb, they may think the skb payload changes. It's even misleading for us when we're looking into an skb with encap and encryption, the len value reflects "wrong" indication. My commit changes its value to L3 len, reduces confusion, but also causes another confusion: for those who know how skb->len works in kernel, the unchanges len values look fishy. I'm not sure it's a good commit or not. Feel free to reject it if you don't think it's right. |
jschwinger233
changed the title
jschwinger233
force-pushed
the
gray/arp
branch
from
66db1b5 to
45ce5a0
Compare
Member
Author
|
Never mind, after a second thought I think it's a bad idea. Just dropped that change. |
* ,--------------------------- + head * / ,----------------- + data * / / ,----------- + tail * | | | , + end * | | | | * v v v v * ----------------------------------------------- * | headroom | data | tailroom | skb_shared_info | * ----------------------------------------------- According to above illustration of skb, data_end should be skb->head + skb->tail. Signed-off-by: Zhichuan Liang <[email protected]>
Signed-off-by: Zhichuan Liang <[email protected]>
Signed-off-by: Zhichuan Liang <[email protected]>
jschwinger233
force-pushed
the
gray/arp
branch
3 times, most recently
from
fb947bf to
b08a66a
Compare
Signed-off-by: Zhichuan Liang <[email protected]>
jschwinger233
force-pushed
the
gray/arp
branch
from
b08a66a to
7ae91dd
Compare
brb
approved these changes
Sep 25, 2023
| pcap_compile mode only works for a complete frame data. | ||
| */ | ||
| pcap := C.pcap_open_dead(C.DLT_RAW, MAXIMUM_SNAPLEN) | ||
| pcap := C.pcap_open_dead(C.DLT_EN10MB, MAXIMUM_SNAPLEN) |
Member
There was a problem hiding this comment.
Nit: does the Go compiler optimize this statement? I.e., pcap := C.pcap_open_dead(C.DLT_EN10MB, MAXIMUM_SNAPLEN) is called only if l3=false?
|
@jschwinger233 Hello, Can pwru display macAddr when package type is arp? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #233
Signed-off-by: Zhichuan Liang [email protected]