Merged
Conversation
sayboras
force-pushed
the
pr/tammach/llvm-19
branch
from
36962b5 to
aab75d7
Compare
Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
pr/tammach/llvm-19
branch
from
aab75d7 to
4674e67
Compare
ti-mo
approved these changes
May 20, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Awesome, thank you! I'll ack but let's make sure that Cilium PR is all green before merging this one.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using clang 19 locally for quite some time, it seems working well with current cilium codebase (except one minor change in test)
Upstream cilium/cilium#39632