Conversation
Linux doesn't care whether we provide an output buffer, Windows does and returns an opaque EOTHER. Signed-off-by: Lorenz Bauer <[email protected]>
lmb
force-pushed
the
windows-program-sample
branch
3 times, most recently
from
1174c41 to
92f79da
Compare
lmb
requested review from
a team,
dylandreimerink,
florianl and
ti-mo
as code owners
florianl
reviewed
Oct 16, 2025
Contributor
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
On a first look, the changes are fine for me and I just have minor comments. Will have a second look.
lmb
force-pushed
the
windows-program-sample
branch
from
92f79da to
851e608
Compare
The upstream efW removed the XDP_TEST program type from the repository. We rely on this type for our unit tests. Switch tests to the SAMPLE program type, which is a separate driver but also distributed as part of the efW runtime. On Windows, running a SAMPLE program requires providing a (possibly empty) context. To avoid having to change a lot of tests over and over we introduce a new mustRun helper. See: microsoft/ebpf-for-windows#4662 Signed-off-by: Lorenz Bauer <[email protected]>
Switch from using setup-ebpf.ps1 to install_ebpf.psm1. This is what efW is doing for their CI as well. Signed-off-by: Lorenz Bauer <[email protected]>
lmb
force-pushed
the
windows-program-sample
branch
from
851e608 to
98d0b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows CI breaking due to microsoft/ebpf-for-windows#4662 by switching to a different program type which is distributed as part of sample_ebpf_ext. Unfortunately Windows stricter requirements on BPF_PROG_RUN for this program type. Instead of adding lots of Windows specific code to tests we break
Program.BenchmarkandProgram.Testand add some compat code in there.See the individual commit messages for more context.