ringbuf: fix read after close panic#1859
Merged
dylandreimerink merged 1 commit intocilium:mainfrom Sep 1, 2025
Merged
Conversation
RonFed
force-pushed
the
ringbuf_read_after_close
branch
from
212c9a6 to
b8a360e
Compare
Signed-off-by: Ron Federman <[email protected]>
RonFed
force-pushed
the
ringbuf_read_after_close
branch
from
b8a360e to
55fdd1b
Compare
florianl
approved these changes
Aug 28, 2025
Contributor
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
dylandreimerink
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue describe in #1857.
Following #1849, the
Closefunction was changed to not set the ring to nil.The panic happens when
r.haveDatais true, aClosehappens and then anotherRead.Added a test that reproduces the panic.