Merged
Conversation
lmb
reviewed
Aug 11, 2025
Contributor
Author
|
depends on #1845. we can proceed with this once the MR get merged. |
Contributor
Author
shun159
changed the title
shun159
force-pushed
the
feature/link_progfd
branch
2 times, most recently
from
9e3fd87 to
9ac72a1
Compare
shun159
force-pushed
the
feature/link_progfd
branch
2 times, most recently
from
ee17ec4 to
c28d238
Compare
lmb
suggested changes
Nov 3, 2025
lmb
reviewed
Nov 3, 2025
shun159
commented
Nov 3, 2025
shun159
force-pushed
the
feature/link_progfd
branch
from
2d66547 to
fd28dea
Compare
Contributor
Author
|
it looks like the tests are also failing on arm64. |
Contributor
|
Windows has fixed itself, arm64 hasn't been changed. Made an issue: #1888 |
lmb
reviewed
Nov 4, 2025
Contributor
Author
got it 🫡 |
shun159
commented
Nov 4, 2025
shun159
force-pushed
the
feature/link_progfd
branch
from
6903f62 to
8b27114
Compare
Allow attaching a StructOpsMap as a link. See: cilium#1502 Co-developed-by: Lorenz Bauer <[email protected]> Signed-off-by: shun159 <[email protected]>
lmb
force-pushed
the
feature/link_progfd
branch
from
8b27114 to
d18136b
Compare
Ensure that structOpsLink conforms to the Link conventions by invoking testLink. This requires implementing some further bits. Signed-off-by: Lorenz Bauer <[email protected]>
lmb
approved these changes
Nov 5, 2025
Contributor
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
I've made some small cosmetic changes by moving code around and added one commit which tidies up the Link implementation.
Thanks for your hard work on this feature!
Contributor
Author
|
@lmb I’m really happy that I was able to make this contribution with you. Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends RawLinkOptions with an optional ProgramFd so callers can attach link types whose target isn't a bpf_prog (e.g. struct_ops maps).
See: #1502