prog: Allow explicit ifindex specification#1842
Merged
ti-mo merged 1 commit intocilium:mainfrom Sep 8, 2025
Merged
Conversation
lmb
suggested changes
Aug 4, 2025
Contributor
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Is it possible to bind an XDP program to lo? If yes, please add a unit test.
Contributor
Author
|
It seems to be possible to bind XDP programs to |
twaapo
force-pushed
the
main
branch
2 times, most recently
from
1776e56 to
5d62ce6
Compare
lmb
reviewed
Aug 7, 2025
Contributor
How about adding a test which just loads a minimal XDP program which is bound to lo, without the kfunc? (There are plenty examples in the code base) I think that is enough to validate that binding works. Kfuncs already have coverage otherwise. |
Contributor
Author
|
Theres a caveat: Where ifindex=3 is Intel XL710 NIC. Seems not to work with |
Contributor
|
Turned the test into a negative check instead. |
lmb
previously approved these changes
Aug 11, 2025
lmb
force-pushed
the
main
branch
3 times, most recently
from
94be5aa to
51c0529
Compare
ti-mo
force-pushed
the
main
branch
2 times, most recently
from
2058fd4 to
4a80553
Compare
Signed-off-by: Aapo Poutanen <[email protected]> Co-authored-by: Timo Beckers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1841