Merged
Conversation
Signed-off-by: Florian Lehner <[email protected]>
Contributor
|
I see that |
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Contributor
Author
|
sorry for the delayed response 🙏
With 2520bb8 I have added such a test.
With c92c648 I have added an error wrapper. Hope this is fine for you. |
Signed-off-by: Florian Lehner <[email protected]>
Contributor
|
lgtm! there are some failing CI jobs, not sure they are related |
Contributor
Author
They don't seem to be related: This is also reported in #1734 |
mmat11
approved these changes
Aug 11, 2025
Contributor
mmat11
left a comment
There was a problem hiding this comment.
Sorry for the delay, I thought I approved already 🙈
lmb
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bpf_link_detach() functionality.