prog: speed up opening pinned Programs#1822
Merged
lmb merged 1 commit intocilium:mainfrom Jul 18, 2025
Merged
Conversation
With commit df9ebe8 the opening of programs by fd was improved. The LoadPinnedProgram still uses to full ProgramInfo instead of the sufficient minimal one. This commit improves the load of pinned Programs as well by using the central helper for creating programs from a fd. This also makes it more consistent with the LoadPinnedMap function as well. Signed-off-by: Tobias Böhm <[email protected]>
ti-mo
approved these changes
Jul 16, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Thanks Tobias! Not sure how I missed this one. Have you done a broader check for similar cases? Clearly I didn't find them all, and I'm currently on leave. 😅
Contributor
Author
|
Yes, I have checked for other uses of the functions providing the full info. They are only used for the actual |
florianl
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With commit df9ebe8 the opening of programs by fd was improved. The LoadPinnedProgram still uses to full ProgramInfo instead of the sufficient minimal one.
This commit improves the load of pinned Programs as well by using the central helper for creating programs from a fd. This also makes it more consistent with the LoadPinnedMap function as well.