collection: drop unnecessary kallsyms module lookup#1821
Merged
lmb merged 2 commits intocilium:mainfrom Jul 14, 2025
Merged
Conversation
The library doesn't rely on knowing symbol module names anymore. Drop some dead code which was missed during that refactoring. Signed-off-by: Lorenz Bauer <[email protected]>
The library doesn't use these routines anymore. Splitting module lookup from address lookup also doesn't really make sense because the really expensive part is parsing /proc/kallsyms, not storing a bit of extra metadata. Signed-off-by: Lorenz Bauer <[email protected]>
Contributor
Author
|
@ti-mo not sure how attached you are to the modules code, I think it's easy to bring back if we do end up needing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collection: drop unnecessary kallsyms module lookup
internal/kallsyms: drop Module, AssignModules