Merged
Conversation
ti-mo
requested changes
Jul 7, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Thank you! Could you also change TestLoadSplitSpecFromReader to use LoadSplitSpec instead, and rename it to TestLoadSplitSpec?
tdaudi
force-pushed
the
pr/tdaudi/add_LoadSplitSpec
branch
from
d08a47b to
6eeda31
Compare
Contributor
Author
Sure ! I added another commit for this. |
tdaudi
force-pushed
the
pr/tdaudi/add_LoadSplitSpec
branch
from
6eeda31 to
b922053
Compare
Similarly to LoadSpec, LoadSplitSpec could make an easier use of split-BTF files Signed-off-by: Tristan d'Audibert <[email protected]>
This commit update `TestLoadSplitSpecFromReader` to use `LoadSplitSpec` and rename the function to `TestLoadSplitSpec` Signed-off-by: Tristan d'Audibert <[email protected]>
tdaudi
force-pushed
the
pr/tdaudi/add_LoadSplitSpec
branch
from
b922053 to
40ab2f4
Compare
Contributor
Author
|
Sorry for the noise, I pushed the commits with the wrong email |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to LoadSpec, LoadSplitSpec could make an easier use of split-BTF files