elf_reader: do not panic in loadMapsif ELF file has no BTF#1807
Merged
lmb merged 1 commit intocilium:mainfrom Jun 20, 2025
Merged
elf_reader: do not panic in loadMapsif ELF file has no BTF#1807lmb merged 1 commit intocilium:mainfrom
loadMapsif ELF file has no BTF#1807lmb merged 1 commit intocilium:mainfrom
Conversation
3f1a755 introduced the ability to read btf_decl_tag attributes set on maps but `loadMaps` is crashing if the ELF file has no BTF. Fix this by checking if the BTF is there before querying it. Signed-off-by: Paul Cacheux <[email protected]>
florianl
approved these changes
Jun 19, 2025
lmb
approved these changes
Jun 20, 2025
Contributor
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Out of curiosity, how come you still have ELF without BTF?
Contributor
Author
|
Definitely not something we ship, just something that we run in our CI and that it seems is using some outdated build commands (that I will update) |
Contributor
|
Thanks! I've created a follow-up to this: #1810. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3f1a755 introduced the ability to read btf_decl_tag attributes set on maps but
loadMapsis crashing if the ELF file has no BTF.Fix this by checking if the BTF is there before querying it.