bpf2go: import package structs when all structs are typedefs#1798
Merged
ti-mo merged 1 commit intocilium:mainfrom Jun 10, 2025
Merged
bpf2go: import package structs when all structs are typedefs#1798ti-mo merged 1 commit intocilium:mainfrom
ti-mo merged 1 commit intocilium:mainfrom
Conversation
When deciding whether to import package structs, the logic only considered typical struct declarations. Typedefs also need to be taken into account. Signed-off-by: Ron Federman <[email protected]> Co-authored-by: Timo Beckers <[email protected]>
ti-mo
force-pushed
the
bpf2go_structs_import_fix
branch
from
872d5cd to
3f9adc7
Compare
ti-mo
changed the title
ti-mo
approved these changes
Jun 10, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Thanks! I changed the check to use btf.As.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code checks for the existence of any
btf.Structwhen deciding to import the "structs" package.Change this to check the underlying type is struct. This handles cases where all the structs are using
typedef.