bpf2go, btf: emit structs.HostLayout in GoFormatter#1769
Merged
lmb merged 1 commit intocilium:mainfrom May 7, 2025
Merged
Conversation
lmb
force-pushed
the
bpf2go-structs-hostlayout
branch
from
e0ec582 to
b8e8084
Compare
ti-mo
reviewed
May 6, 2025
ti-mo
approved these changes
May 6, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Nice! One nit, and you forgot to update the test battery in TestGoTypeDeclaration.
Types described by BTF essentially follow C rules for laying out a struct. Use the newly introduced structs.HostLayout to hint at the compiler that reordering is not permissible. Fixes cilium#1686 Signed-off-by: Lorenz Bauer <[email protected]>
lmb
force-pushed
the
bpf2go-structs-hostlayout
branch
from
b8e8084 to
1967520
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types described by BTF essentially follow C rules for laying out a struct. Use the newly introduced structs.HostLayout to hint at the compiler that reordering is not permissible.
Fixes #1686