map: unmarshal values for partial batch#1742
Merged
lmb merged 1 commit intocilium:mainfrom Apr 16, 2025
Merged
Conversation
Contributor
|
Oof, thanks. Do you think you can extend the unit tests to cover this case? |
Contributor
Author
|
I could add a test that uses a Do you think this should be a new separate test? Or do you have an existing test function in mind that should be extended with a test case for this issue? |
d7a28ae to
e45940d
Compare
Contributor
Author
|
I have added a new test function that tests key and value unmarshaling with a custom |
In case of a partial batch the values are not unmarshalled in BatchLookup and BatchLookupDelete for non-perCPU maps. This commit fixes it by adapting the error handling from batchLookupPerCPU. Fixes cilium#1741 Signed-off-by: Tobias Böhm <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of a partial batch the values are not unmarshalled in BatchLookup and BatchLookupDelete for non-perCPU maps.
This commit fixes it by adapting the error handling from batchLookupPerCPU.
Fixes #1741