I force-pushed this branch to read go 1.23, but this somehow makes golangci-lint unable to run: https://github.com/cilium/ebpf/actions/runs/14054937043/job/39352226944?pr=1729

Reading eaef6a7 again:

On b3432fb, the minimum supported Go version was updated to 1.21.0. This changes the version to 1.21 so that we are using a language version. If not using toolchain, this seems to be the preferred convention in the ecosystem and golang/go.

Seems to me like go mod tidy behaviour changes depending on the used toolchain, so putting a toolchain directive in go.mod seems like the best way to keep this behaviour stable in the same sense that e.g. an LLVM builder image does.

Bottom line is eaef6a7 may no longer be an issue if both go 1.23.0 and toolchain go1.24.1 are specified. I've run go mod tidy on the dependabot PR and force-pushed it; looks like it's working. Let's go with the initial PR.

I force-pushed this branch to read go 1.23, but this somehow makes golangci-lint unable to run: https://github.com/cilium/ebpf/actions/runs/14054937043/job/39352226944?pr=1729

Reading eaef6a7 again:

On b3432fb, the minimum supported Go version was updated to 1.21.0. This changes the version to 1.21 so that we are using a language version. If not using toolchain, this seems to be the preferred convention in the ecosystem and golang/go.

Seems to me like go mod tidy behaviour changes depending on the used toolchain, so putting a toolchain directive in go.mod seems like the best way to keep this behaviour stable in the same sense that e.g. an LLVM builder image does.

Bottom line is eaef6a7 may no longer be an issue if both go 1.23.0 and toolchain go1.24.1 are specified. I've run go mod tidy on the dependabot PR and force-pushed it; looks like it's working. Let's go with the initial PR.

AFAIK, if the go directive includes a patch version, a toolchain directive shouldn't be necessary and won't be added by go mod tidy. Given that go specifies the minimum language version and there are no language changes to be expected between patch versions, the safest way IMO would be to use go 1.x.0 and no toolchain directive. That way developers won't be forced to update their toolchain (as is currently the case with the toolchain go1.24.1 directive which will force developers using go1.24.0 to update). This is the scheme that's currently used in cilium/cilium and has worked quite well so far.

If you want I can send a follow-up patch changing to the above.

Nevermind, I missed that go and toolchain are different 🤦 the current approach seems fine to me.