Conversation
ti-mo
reviewed
Feb 25, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Ack on the concept, left one comment.
Introduce helpers for creating a map, program, collection from a spec. Additionally, add helpers which create very common types like arrays or socket filter programs. This significantly cuts down on boiler plate in unit tests, and ensures that all resources backed by a file descriptor are cleaned up. It will also allow adding compatibility code for running Linux unit tests on Windows in a central location. Signed-off-by: Lorenz Bauer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce helpers for creating a map, program, collection from a spec. Additionally, add helpers which create very common types like arrays or socket filter programs.
This significantly cuts down on boiler plate in unit tests, and ensures that all resources backed by a file descriptor are cleaned up.
It will also allow adding compatibility code for running Linux unit tests on Windows in a central location.