memory: fix off-by-one in bounds check#1694
Merged
ti-mo merged 1 commit intocilium:mainfrom Feb 20, 2025
Merged
Conversation
It previously wasn't possible to access the last byte of the memory segment. Also add a u64 overflow check. This wasn't caught in tests because this requires accessing a page-aligned variable in its entirety. Add a test with a page-aligned array Variable. Signed-off-by: Timo Beckers <[email protected]>
mejedi
approved these changes
Feb 20, 2025
Contributor
mejedi
left a comment
mejedi
left a comment
There was a problem hiding this comment.
Thank you for making a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It previously wasn't possible to access the last byte of the memory segment. Also add a u64 overflow check.
This wasn't caught in tests because this requires accessing a page-aligned variable in its entirety. Add a test with a page-aligned array Variable.
cc @mejedi