linker: do not copy instructions when there is no reference in flattenInstructions#1647
Merged
ti-mo merged 1 commit intocilium:mainfrom Jan 24, 2025
Merged
Conversation
paulcacheux
force-pushed
the
flatten-instructions-opt
branch
from
8056168 to
9ebb561
Compare
lmb
previously requested changes
Jan 21, 2025
Contributor
lmb
left a comment
lmb
left a comment
There was a problem hiding this comment.
Could you add a test using testing.AllocsPerRun to make sure this doesn't regress?
paulcacheux
force-pushed
the
flatten-instructions-opt
branch
from
9ebb561 to
610f088
Compare
When resolving the bpf-to-bpf calls we need to copy the instructions from the program to flatten the references. But when there is no reference there is nothing to do so we can skip the copy operation altogether. Signed-off-by: Paul Cacheux <[email protected]>
paulcacheux
force-pushed
the
flatten-instructions-opt
branch
from
610f088 to
21eb181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving the bpf-to-bpf calls we need to copy the instructions from the program to flatten the references.
But when there is no reference there is nothing to do so we can skip the copy operation altogether.