prog: fix tautological AttachTo condition in ProgramSpec.kernelModule#1640
Merged
ti-mo merged 2 commits intocilium:mainfrom Jan 15, 2025
Merged
prog: fix tautological AttachTo condition in ProgramSpec.kernelModule#1640ti-mo merged 2 commits intocilium:mainfrom
ti-mo merged 2 commits intocilium:mainfrom
Conversation
ti-mo
requested changes
Jan 8, 2025
Contributor
ti-mo
left a comment
ti-mo
left a comment
There was a problem hiding this comment.
Thanks! If this made it through, that means test coverage is lacking. Maybe now's a good opportunity to add one? You can assume bpf_testmod is loaded in CI if that helps.
Contributor
Author
|
@ti-mo added some tests |
This allows calling requireTestmod in a loop for marking subtests as requiring bpf_testmod. Signed-off-by: Timo Beckers <[email protected]>
This fixes a bug introduced by a refactor in 0.17. targetsKernelModule() already checks for AttachTo == "", so drop the statement. Signed-off-by: Bryce Kahle <[email protected]> Co-authored-by: Timo Beckers <[email protected]>
ti-mo
force-pushed
the
bryce.kahle/fix-kernel-module
branch
from
a850752 to
fbf9bb0
Compare
ti-mo
changed the title
ti-mo
approved these changes
Jan 15, 2025
Contributor
Author
|
@ti-mo any chance of getting a minor release for this fix? I don't think kernel module programs will work without it. |
Contributor
@brycekahle Yep, aiming for Mon/Tues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should've been
ps.AttachTo != "", buttargetsKernelModulealready checks that condition, so just remove it completely.