prog: add ProgramOptions.LogSizeStart to obtain full log after verifier bug#1630
Merged
ti-mo merged 2 commits intocilium:mainfrom Dec 18, 2024
Merged
prog: add ProgramOptions.LogSizeStart to obtain full log after verifier bug#1630ti-mo merged 2 commits intocilium:mainfrom
ti-mo merged 2 commits intocilium:mainfrom
Conversation
ti-mo
force-pushed
the
tb/revive-logsize
branch
2 times, most recently
from
fad6c41 to
657e854
Compare
florianl
approved these changes
Dec 18, 2024
Signed-off-by: Timo Beckers <[email protected]>
…er bug When the verifier hits a bug, it returns EFAULT while clobbering other retcodes. This defeats the buffer growth algorithm, so the user needs a break-glass procedure for obtaining the full verifier log. Also, reinstate maxVerifierLogSize since the maxu32 >> 2 limit is still in effect in the Linux kernel. This can be removed if the limit is removed one day and someone has a verifier log that's actually this big. EFAULT can't be reliably triggered in CI, and I'm currently out of ideas for testing this. Signed-off-by: Timo Beckers <[email protected]>
ti-mo
force-pushed
the
tb/revive-logsize
branch
from
657e854 to
6394ee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the verifier hits a bug, it returns EFAULT while clobbering other retcodes. This defeats the buffer growth algorithm, so the user needs a break-glass procedure for obtaining the full verifier log.
Also, reinstate maxVerifierLogSize since the maxu32 >> 2 limit is still in effect in the Linux kernel. This can be removed if the limit is removed one day and someone has a verifier log that's actually this big.
EFAULT can't be reliably triggered in CI, and I'm currently out of ideas for testing this.
Fixes #1554