elf_reader: support value BTF on ringbuf and perf array maps #1628
Merged
ti-mo merged 2 commits intocilium:mainfrom Dec 16, 2024
Merged
elf_reader: support value BTF on ringbuf and perf array maps #1628ti-mo merged 2 commits intocilium:mainfrom
ti-mo merged 2 commits intocilium:mainfrom
Conversation
While reviewing cilium#1610, I noticed we were generating VariableSpecs for variables named 'unused' in our examples. There had to be a better way to get their BTF info into the ELF. I thoroughly checked all map types present in Linux 6.12 for any validation code on attr->value_size, and only RingBuf and Arena maps require value_size to be zero at all times. Special-case PerfEventArray so type annotations aren't limited to 4 bytes. Signed-off-by: Timo Beckers <[email protected]>
…rmation This obviates the need for declaring these unused variables, which would otherwise get included in bpf2go-generated Go code in a follow-up commit. Signed-off-by: Timo Beckers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @smagnani96 This should clean up the bpf2go output a bit. I'll rebase your PR when this is merged.