elf_reader: support referencing weak variables#1571
Merged
ti-mo merged 1 commit intocilium:mainfrom Oct 1, 2024
Merged
Conversation
Our existing tests included a weak symbol, but it wasn't referenced in code and it ended up in .bss where other symbols sit at the same index. This confused the loader into thinking the symbol was referenced, though there were no actual symbol references to it in bpf code. Signed-off-by: Timo Beckers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our existing tests included a weak symbol, but it wasn't referenced in code and it ended up in .bss where other symbols sit at the same index. This confused the loader into thinking the symbol was referenced, though there were no actual symbol references to it in bpf code.