Merged
Conversation
dylandreimerink
approved these changes
Jul 22, 2024
Member
dylandreimerink
left a comment
dylandreimerink
left a comment
There was a problem hiding this comment.
This looks good to me. I was wondering why you decided to roll your own deep equal instead of the std reflect function? Is this better in some way?
The are multiple Copy() methods in the code base which are used to create deep copies of a struct. Any bugs in them can manifest as data races in concurrent code. Add a quicktest checker which ensures that two variables are a deep copy of each other: values match, but all locations in memory differ. Fix a variety of problems with the existing Copy() implementations. They all allow copying a nil struct and copy all elements. There are exceptions to the deep copy rule: - MapSpec.Contents is not deep copied because we can't easily make copies of interface values. This is documented already. - MapSpec.Extra is an immutable bytes.Reader and therefore only needs a shallow copy. - ProgramSpec.AttachTarget is a Program, which is (currently) safe for concurrent use. Fixes cilium#1517 Signed-off-by: Lorenz Bauer <[email protected]>
Contributor
Author
|
I added the following comment: Does that make it clearer? |
Member
|
Yep, much better. I figured it would be something like that. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The are multiple Copy() methods in the code base which are used to create deep copies of a struct. Any bugs in them can manifest as data races in concurrent code.
Add a quicktest checker which ensures that two variables are a deep copy of each other: values match, but all locations in memory differ.
Fix a variety of problems with the existing Copy() implementations. They all allow copying a nil struct and copy all elements.
There are exceptions to the deep copy rule:
Fixes #1517