info: make it harder to add backwards incompatible API#1515
Merged
lmb merged 1 commit intocilium:mainfrom Jul 15, 2024
Merged
Conversation
People adding new fields to the Info API always get tripped up by how it works. Add a comment which explains why it works the way it does. Also add a test which ensures that new exported fields are only added when they are really warranted. Signed-off-by: Lorenz Bauer <[email protected]>
florianl
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People adding new fields to the Info API always get tripped up by how it works. Add a comment which explains why it works the way it does. Also add a test which ensures that new exported fields are only added when they are really warranted.