Skip to content

Comments

link: fix nil pointer dereference in AttachXDP#1507

Merged
lmb merged 1 commit intocilium:mainfrom
gavinbunney:gavin/nil-link
Jul 15, 2024
Merged

link: fix nil pointer dereference in AttachXDP#1507
lmb merged 1 commit intocilium:mainfrom
gavinbunney:gavin/nil-link

Conversation

@gavinbunney
Copy link
Contributor

@gavinbunney gavinbunney commented Jul 10, 2024

With the change in #1435, failures to attach to a XDP link cause a nil pointer dereference. This change ensures any error returned from AttachRawLink is handled correctly.

@gavinbunney gavinbunney requested a review from mmat11 as a code owner July 10, 2024 00:32
@lmb lmb force-pushed the gavin/nil-link branch from b83c276 to b8379a5 Compare July 15, 2024 10:12
Copy link
Contributor

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added a basic test.

@lmb lmb changed the title link: fix nil pointer dereference link: fix nil pointer dereference in AttachXDP Jul 15, 2024
@lmb lmb merged commit 88e8f88 into cilium:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants