program: don't return error when kmod BTF is disabled#1440
Merged
lmb merged 1 commit intocilium:mainfrom Apr 22, 2024
Merged
Conversation
orishuss
force-pushed
the
bugfix/kernel-module-program-relocation-fail
branch
2 times, most recently
from
89722af to
a52d372
Compare
dylandreimerink
approved these changes
Apr 17, 2024
Member
dylandreimerink
left a comment
dylandreimerink
left a comment
There was a problem hiding this comment.
Changes look good to me. Note that the commit isn't signed off
Contributor
|
Could you extend |
orishuss
force-pushed
the
bugfix/kernel-module-program-relocation-fail
branch
4 times, most recently
from
c035ab3 to
9b6aefc
Compare
lmb
force-pushed
the
bugfix/kernel-module-program-relocation-fail
branch
from
1b7ad20 to
3b9d208
Compare
lmb
changed the title
Contributor
|
I've had to drop the test in manyprogs.c since the file is only used from benchmarks. I tried to come up with a way to test this in CI, but it's not straight forward :( I also updated your first commit to include the useful PR description. Unrelated to this, I want to make sure that the new semantics actually make sense.
|
In kernels where the flag CONFIG_DEBUG_INFO_BTF_MODULES is not set, including kernels 5.10 and below (because the flag was introduced in 5.11), loading a program that attaches to kernel module functions and relied on CORE failed because the module's BTF is not available. This fix allows the program to run, obviously only as long as it only relies on the kernel's BTF and not on the specific module's BTF. Fixes: cilium#1436 Signed-off-by: Ori Shussman <[email protected]>
lmb
force-pushed
the
bugfix/kernel-module-program-relocation-fail
branch
from
3b9d208 to
085d688
Compare
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In kernels where the flag
CONFIG_DEBUG_INFO_BTF_MODULESis not set, including kernels 5.10 and below (because the flag was introduced in 5.11), loading a program that attaches to kernel module functions and relied on CORE failed because the module's BTF is not available.This fix allows the program to run, obviously only as long as it only relies on the kernel's BTF and not on the specific module's BTF.
Fixes: #1436. Tested on the same example included in the issue: when using the fixed package, the program attaches successfully.