Skip to content

Comments

perf: fix TestPerfReaderWakeupEvents#1423

Merged
lmb merged 1 commit intocilium:mainfrom
lmb:reader-fix-hang
Apr 10, 2024
Merged

perf: fix TestPerfReaderWakeupEvents#1423
lmb merged 1 commit intocilium:mainfrom
lmb:reader-fix-hang

Conversation

@lmb
Copy link
Contributor

@lmb lmb commented Apr 9, 2024

The WakeupEvents limit is per ring, one per CPU. And when we execute BPF_PROG_RUN multiple times, we sometimes execute on different CPUs. This means that samples don't all go into a single ring.

Fix this by forcing the producer to run on a single CPU.

Co-developed-by: Dylan Reimerink [email protected]

The WakeupEvents limit is per ring, one per CPU. And when we execute
BPF_PROG_RUN multiple times, we sometimes execute on different CPUs.
This means that samples don't all go into a single ring.

Fix this by forcing the producer to run on a single CPU.

Fixes cilium#1419

Co-developed-by: Dylan Reimerink <[email protected]>
Signed-off-by: Lorenz Bauer <[email protected]>
@lmb lmb force-pushed the reader-fix-hang branch from 65e0f28 to 96f627b Compare April 9, 2024 12:09
@lmb lmb marked this pull request as ready for review April 10, 2024 09:55
@lmb lmb requested review from a team and florianl as code owners April 10, 2024 09:55
@lmb
Copy link
Contributor Author

lmb commented Apr 10, 2024

I'll go ahead and merge this since it makes CI pretty flaky.

@lmb lmb merged commit bbb2c07 into cilium:main Apr 10, 2024
@lmb lmb deleted the reader-fix-hang branch April 10, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant