Skip to content

Comments

when ringbuffer map size is not a power-of-2 multiple of page size, prompt users in a user-friendly way#1420

Merged
lmb merged 2 commits intocilium:mainfrom
hengyoush:ring-map-size-error
Apr 10, 2024
Merged

when ringbuffer map size is not a power-of-2 multiple of page size, prompt users in a user-friendly way#1420
lmb merged 2 commits intocilium:mainfrom
hengyoush:ring-map-size-error

Conversation

@hengyoush
Copy link

@hengyoush hengyoush commented Apr 8, 2024

example:

struct {
	__uint(type, BPF_MAP_TYPE_RINGBUF);
	__uint(max_entries, 4097);
} rb SEC(".maps");

then output:

program dev_hard_start_xmit: map rb: EINVAL (ring map size 4097 not a power of two page size(pageSize 4096))

@hengyoush hengyoush requested a review from a team as a code owner April 8, 2024 06:32
@hengyoush hengyoush force-pushed the ring-map-size-error branch from 4c4228f to 7638f55 Compare April 8, 2024 06:35
florianl
florianl reviewed Apr 8, 2024
View reviewed changes
@hengyoush hengyoush force-pushed the ring-map-size-error branch from 3c49b2e to f8c12e5 Compare April 8, 2024 09:37
@hengyoush hengyoush requested a review from florianl April 8, 2024 09:38
@lmb
internal: move IsPow
53f55c4 
Move pow() from package btf to package internal.

Signed-off-by: Lorenz Bauer <[email protected]>
@lmb lmb force-pushed the ring-map-size-error branch from f8c12e5 to d882b65 Compare April 10, 2024 09:52
@lmb
Copy link
Contributor

lmb commented Apr 10, 2024

I've pushed a small refactoring to reuse an existing implementation of pow we already had in the code base.

lmb
lmb suggested changes Apr 10, 2024
View reviewed changes
@lmb lmb force-pushed the ring-map-size-error branch from 7c294df to 7e0b9c1 Compare April 10, 2024 11:31
@lmb lmb merged commit d4bceb5 into cilium:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florianl florianl florianl approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

+1 more reviewer

@lmb lmb lmb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hengyoush @lmb @florianl @dylandreimerink