add WakeupEvents support to perf Reader#1404
Merged
lmb merged 1 commit intocilium:mainfrom Apr 3, 2024
Merged
Conversation
Signed-off-by: Bryce Kahle <[email protected]>
brycekahle
force-pushed
the
bryce.kahle/wakeup-events
branch
from
e56a8c8 to
01282fa
Compare
florianl
reviewed
Apr 2, 2024
Contributor
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
Thanks for the PR 🙏
Just a minor request for an additional check in createPerfEvent.
florianl
approved these changes
Apr 2, 2024
Member
|
Hi! It seems this PR introduced a flaky test, see #1419. @brycekahle could you take a look? So far I have not been able to find the root cause, will update the issue if I do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #524 with only the
WakeupEventsportion.