Merged
Conversation
Replace uses of ClangEndian with a NativeFile test utility. Signed-off-by: Lorenz Bauer <[email protected]>
We have a lot of tests which first glob a list of files containing BPF for little and big endian, then parse those files and finally skip a test if the files endianness doesn't match the native endianness. This is pretty wasteful, since we parse BPF for no good reason and makes the tests more verbose than they have to be. Use NativeFile instead and remove almost all checks for IsNativeEndian from tests. The two remaining cases are in the ELF loader tests, where they do have value: we want to make sure that we can parse things from any endianness. Signed-off-by: Lorenz Bauer <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal: remove ClangEndian
tests: remove !IsNativeEndian skips