elf_reader_test: Fix CI by disabling the "test_log_fixup" selftest#1385
Merged
lmb merged 1 commit intocilium:mainfrom Mar 21, 2024
Merged
elf_reader_test: Fix CI by disabling the "test_log_fixup" selftest#1385lmb merged 1 commit intocilium:mainfrom
lmb merged 1 commit intocilium:mainfrom
Conversation
The "test_log_fixup" selftest is broken on purpose, with the goal of testing error messages. Due to changes in cilium#1364 we now emit a poison instruction in `bad_relo_subprog` on a instruction which also has a reference to a BPF-to-BPF function. This causes the symbol/reference resolution step to fail. This error is flaky, it only happens when `bad_relo_subprog` is loaded first. If any other program in the collection is loaded first due to random hash map ordering we skip the test instead due to the test checking for verifier errors. Since this test is broken on purpose, we previously just always hit this skip condition. This commit disabled this selftest explicitly which resolves the CI flakiness. Signed-off-by: Dylan Reimerink <[email protected]>
Contributor
Ah TIL. It'd be nice to not rely on ordering, oh well |
lmb
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "test_log_fixup" selftest is broken on purpose, with the goal of testing error messages. Due to changes in #1364 we now emit a poison instruction in
bad_relo_subprogon a instruction which also has a reference to a BPF-to-BPF function. This causes the symbol/reference resolution step to fail.This error is flaky, it only happens when
bad_relo_subprogis loaded first. If any other program in the collection is loaded first due to random hash map ordering we skip the test instead due to the test checking for verifier errors.Since this test is broken on purpose, we previously just always hit this skip condition. This commit disabled this selftest explicitly which resolves the CI flakiness.