Conversation
0ca2aa2 to
47be1e0
Compare
There was a problem hiding this comment.
Makes sense overall and the high level goals are very useful to understand the design changes necessary to implement that approach 👍
I have mainly two aspects for consideration in threads below, along with misc feedback:
- I don't understand why the tunnel source must be the Pod IP range. This seems to impose a Pod Prefix routability requirement on the network, which means that even if Cilium doesn't need to know about every destination Pod in the cluster(mesh), the network at least needs to know about the routability information of every Pod in the cluster(mesh).
- This CFP seems to on one hand specify egress policy as a non-goal, but at the same time has quite a few details about making egress policy work (particularly around the DNS handling and ToFQDNs policy). Do you intend to expand the scope of this CFP or move those aspects into a subsequent followup?
9fff40e to
be84a53
Compare
be84a53 to
325675f
Compare
|
Hi there! I wanted to mention Rob proposed xDS adapter for Cilium which may be relevant here, PTAL: https://docs.google.com/document/d/1U4pO_dTaHERKOtrneNA8njW19HSVbq3sBM3x8an4878/edit#heading=h.y3v1ksm0ev6r |
26b63c5 to
99d52ea
Compare
Signed-off-by: Paul Chaignon <[email protected]>
Co-authored-by: Joe Stringer <[email protected]> Signed-off-by: Paul Chaignon <[email protected]>
99d52ea to
66785a1
Compare
joestringer
left a comment
There was a problem hiding this comment.
From what I recall, some parts of this were implemented, but not all. Additionally, some other features like CiliumCIDRGroups may have some overlap which could be worth considering if this is picked up again.
At a high level I scanned through and my feeling at this point is that the core idea of reducing pressure on the ipcache bpf map by changing the model of expected data in there makes sense as a specific feature. I think there was another set of changes in this CFP that were particularly opinionated around exactly how the networking works between nodes which I would ideally split out and consider as a separate point. The latter is related to the same goal of high scalability but IMO has a different design space and implications vs. the ipcache map management problems. These two could be combined for an opinionated architecture but otherwise do not seem to be fundamentally tied to one another.
All that said, I am happy to merge this in the "Dormant" state as-is. If and when we pick this up to move it forward, consider revisiting the above feedback to scope some of the discussions.
No description provided.