Skip to content

all: switch from package syscall to x/sys/unix#588

Merged
tgraf merged 1 commit intocilium:masterfrom
tklauser:syscall-to-x-sys-unix
Apr 21, 2017
Merged

all: switch from package syscall to x/sys/unix#588
tgraf merged 1 commit intocilium:masterfrom
tklauser:syscall-to-x-sys-unix

Conversation

@tklauser
Copy link
Copy Markdown
Member

@tklauser tklauser commented Apr 21, 2017

The syscall package is locked down and the comment in [1] advises to
switch code to use the corresponding package from golang.org/x/sys. Do
so and replace usage of package syscall with package
golang.org/x/sys/unix. This will also allow to get updates and fixes
without having to use a new go version.

[1] https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24

The syscall package is locked down and the comment in [1] advises to
switch code to use the corresponding package from golang.org/x/sys. Do
so and replace usage of package syscall with package
golang.org/x/sys/unix. This will also allow to get updates and fixes
without having to use a new go version.

[1] https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24

Signed-off-by: Tobias Klauser <[email protected]>
Copy link
Copy Markdown
Contributor

@aalemayhu aalemayhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aanm aanm self-requested a review April 21, 2017 17:24
@tgraf
Copy link
Copy Markdown
Contributor

tgraf commented Apr 21, 2017

Thanks @tklauser!

@tgraf tgraf merged commit 21f1faf into cilium:master Apr 21, 2017
@tklauser tklauser deleted the syscall-to-x-sys-unix branch May 8, 2017 10:33
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Aug 3, 2017
Automatic merge from submit-queue

Switch from package syscall to golang.org/x/sys/unix

**What this PR does / why we need it**:

The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes
without having to use a new go version.

In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function.

**Special notes for your reviewer**:

This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588

**Release note**:

```release-note
NONE
```
wgliang pushed a commit to wgliang/utils that referenced this pull request Jun 11, 2018
Automatic merge from submit-queue

Switch from package syscall to golang.org/x/sys/unix

**What this PR does / why we need it**:

The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes
without having to use a new go version.

In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function.

**Special notes for your reviewer**:

This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588

**Release note**:

```release-note
NONE
```
tamalsaha pushed a commit to kmodules/shared-informer that referenced this pull request Aug 13, 2020
Automatic merge from submit-queue

Switch from package syscall to golang.org/x/sys/unix

**What this PR does / why we need it**:

The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes
without having to use a new go version.

In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function.

**Special notes for your reviewer**:

This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 5d24a2c19923d6da46110b827619f4b21cf689ac
tamalsaha pushed a commit to gomodules/jsonpath that referenced this pull request Apr 21, 2021
Automatic merge from submit-queue

Switch from package syscall to golang.org/x/sys/unix

**What this PR does / why we need it**:

The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes
without having to use a new go version.

In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function.

**Special notes for your reviewer**:

This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 5d24a2c19923d6da46110b827619f4b21cf689ac
tamalsaha pushed a commit to gomodules/jsonpath that referenced this pull request Apr 21, 2021
Automatic merge from submit-queue

Switch from package syscall to golang.org/x/sys/unix

**What this PR does / why we need it**:

The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes
without having to use a new go version.

In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function.

**Special notes for your reviewer**:

This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 5d24a2c19923d6da46110b827619f4b21cf689ac
yoursanonymous pushed a commit to yoursanonymous/cilium that referenced this pull request Jan 31, 2026
* feat: add AI usecase

* feat: add AI usecase

* fix: remove meltwater quote

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* Update src/pages/industries/ai.jsx

Co-authored-by: Bill Mulligan <[email protected]>
Signed-off-by: Paul Arah <[email protected]>

* fix: updates

* fix: add ecco testimonial

* fix: add ecco logo

* fix: update text

* fix job title and punctuation

Signed-off-by: Bill Mulligan <[email protected]>

---------

Signed-off-by: Paul Arah <[email protected]>
Signed-off-by: Bill Mulligan <[email protected]>
Co-authored-by: Bill Mulligan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants