Revert "bpf: conntrack: don't report SYN-ACK as 'observed SYN'" - #47594
Merged
Conversation
maintainer-s-little-helper
Bot
added
the
dont-merge/needs-release-note-label
julianwiedmann
added
area/datapath
maintainer-s-little-helper
Bot
removed
the
dont-merge/needs-release-note-label
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
julianwiedmann
force-pushed
the
pr/jwi/main/dsr-revert
branch
from
July 30, 2026 08:38
bcdb071 to
36f6136
Compare
Member
Author
This becomes a problem once #47593 gets applied and fixes the ingress path (see the test failure there). |
Member
Author
|
(fyi, I'm tracking the whole pending DSR series in #47592) |
julianwiedmann
force-pushed
the
pr/jwi/main/dsr-revert
branch
from
July 30, 2026 09:08
36f6136 to
94952bb
Compare
This reverts commit 82d2d51. The change itself is correct. But it also needs a fix in the ingress path on the remote node, so that nodeport_extract_dsr_v*() doesn't expect DSR-info in the SYN-ACK packet. This will need to go out first for upgrade compatibility reasons. Also update the generated SYN-ACK packet in a few tests that have been added in the meantime. Signed-off-by: Julian Wiedmann <[email protected]>
julianwiedmann
force-pushed
the
pr/jwi/main/dsr-revert
branch
from
July 30, 2026 09:25
94952bb to
4a63123
Compare
Member
Author
|
/test |
|
/test |
julianwiedmann
marked this pull request as ready for review
July 30, 2026 10:32
julianwiedmann
enabled auto-merge
July 30, 2026 10:32
dylandreimerink
approved these changes
Jul 30, 2026
maintainer-s-little-helper
Bot
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 82d2d51.
The change itself is correct. But it also needs a fix in the ingress path on the remote node, so that
nodeport_extract_dsr_v*() doesn't expect DSR-info in the SYN-ACK packet. This will need to go out first for upgrade compatibility reasons.
Also update the generated SYN-ACK packet in a few tests that have been added in the meantime.