gateway-api: handle TCPRoute/UDPRoute in Envoy host network mode - #47430
Merged
mhofstetter merged 1 commit intoJul 24, 2026
Conversation
maintainer-s-little-helper
Bot
added
the
dont-merge/needs-release-note-label
Member
|
lgtm! 🚀 |
Contributor
Author
|
/test |
arybolovlev
force-pushed
the
pr/arybolovlev/handle-tcp-udp-routes-with-host-networking
branch
3 times, most recently
from
July 23, 2026 10:36
0f14f4f to
7d52147
Compare
Contributor
Author
|
Rebased on top of main to address conflict. |
Contributor
Author
|
/test |
1 similar comment
|
/test |
mhofstetter
added
kind/enhancement
maintainer-s-little-helper
Bot
removed
the
dont-merge/needs-release-note-label
Contributor
Author
|
/ci-l3-l4 |
Contributor
Author
|
/test |
arybolovlev
marked this pull request as ready for review
July 23, 2026 14:28
arybolovlev
force-pushed
the
pr/arybolovlev/handle-tcp-udp-routes-with-host-networking
branch
from
July 23, 2026 14:30
7d52147 to
5010706
Compare
Contributor
Author
|
Rebased on main. |
Contributor
Author
|
/test |
1 similar comment
|
/test |
joestringer
added
the
release-blocker/1.20
mhofstetter
reviewed
Jul 24, 2026
mhofstetter
left a comment
mhofstetter
left a comment
Member
There was a problem hiding this comment.
Thanks for this, i left some feedback inline 🚀
Maybe worth to slightly correct the commit message and PR description? IMO something along the following line would be easier to understand and focus on the user-visible parts?
- reject TCP/UDP listeners in host network mode and update Gateway listener status for unsupported L4 listeners
- reject TCP- & UDPRoute objects in host network mode and set unsupported status on route objects
- rejecting TCP/UDP listeners and/or routes doesn't stop the reconciliation of mixed scenarios
arybolovlev
force-pushed
the
pr/arybolovlev/handle-tcp-udp-routes-with-host-networking
branch
from
July 24, 2026 10:25
5010706 to
c0e1d5f
Compare
Contributor
Author
|
/test |
This commit correctly handles TCPRoute and UDPRoute when Envoy runs in host network mode by rejecting unsupported routes, since the current NodePort-based implementation does not work correctly in this mode. - Reject TCP/UDP listeners in host network mode and update Gateway listener status for unsupported L4 listeners. - Reject TCPRoute and UDPRoute objects in host network mode and set unsupported status on route objects. - Rejecting TCP/UDP listeners and/or routes doesn't stop the reconciliation of mixed scenarios. Related to cilium#47234 Signed-off-by: Aleksandr Rybolovlev <[email protected]>
arybolovlev
force-pushed
the
pr/arybolovlev/handle-tcp-udp-routes-with-host-networking
branch
from
July 24, 2026 10:30
c0e1d5f to
6a4063a
Compare
Contributor
Author
|
Rebased on top of main to address conflict. |
Contributor
Author
|
/test |
|
/test |
maintainer-s-little-helper
Bot
added
ready-to-merge
17 tasks
nbusseneau
added
backport-pending/1.20
github-actions
Bot
added
backport-done/1.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit correctly handles TCPRoute and UDPRoute when Envoy runs in host network mode by rejecting unsupported routes, since the current NodePort-based implementation does not work correctly in this mode.
Related to #47234.