operator: Move flags from InitGlobalFlags to appropriate cells#45008
Open
HadrienPatte wants to merge 3 commits intomainfrom
Open
operator: Move flags from InitGlobalFlags to appropriate cells#45008HadrienPatte wants to merge 3 commits intomainfrom
InitGlobalFlags to appropriate cells#45008HadrienPatte wants to merge 3 commits intomainfrom
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
Move clusterpool operator flags (`cluster-pool-ipv4-cidr`, `cluster-pool-ipv4-mask-size`, `cluster-pool-ipv6-cidr` and `cluster-pool-ipv6-mask-size`) registration from the global operator config down to the clusterpool IPAM allocator cell. The flags are now defined and registered closer to where they are used, they are no longer exposed to other cells that don't need them. As a result, the cloud provider variants of the operator (aws/azure/alibaba) no longer regognize those flags (see cmdref diff). Signed-off-by: Hadrien Patte <[email protected]>
Move `pod-restart-selector` flag definition and registration from global operator flags down to the unmanaged pods cell where it belongs. Signed-off-by: Hadrien Patte <[email protected]>
Move `cilium-endpoint-gc-interval` flag registration and definition to the `endpointgc` cell where it belongs. Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
force-pushed
the
pr/HadrienPatte/operator-flags
branch
from
564b02e to
7a3baab
Compare
HadrienPatte
added
area/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some operator flags registration from the global
InitGlobalFlagsto their relevant cells that own them:cluster-pool-ipv4-cidr,cluster-pool-ipv4-mask-size,cluster-pool-ipv6-cidrandcluster-pool-ipv6-mask-size-> clusterpool IPAM allocator cellpod-restart-selector-> unmanaged pods cellcilium-endpoint-gc-interval-> endpoint gc cell