modernize: Enable waitgroup analyzer#44660
Merged
julianwiedmann merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
sig/policy
Member
Author
|
/test |
HadrienPatte
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
HadrienPatte
requested review from
MikeZappa87,
bimmlerd,
devodev,
joamaki,
ti-mo and
tommyp1ckles
devodev
approved these changes
Mar 9, 2026
bimmlerd
approved these changes
Mar 10, 2026
Contributor
tommyp1ckles
left a comment
tommyp1ckles
left a comment
There was a problem hiding this comment.
@HadrienPatte I'm wondering, do we intend to lint/diff for these in CI at some point so we don't regress back to the "old" way?
tommyp1ckles
approved these changes
Mar 11, 2026
Enable the [`waitgroup`](https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#hdr-Analyzer_waitgroup) modernize analyzer globally and address the last remaining failures. Patch generated with `go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -waitgroup ./...` Signed-off-by: Hadrien Patte <[email protected]>
HadrienPatte
force-pushed
the
pr/HadrienPatte/modernize-waitgroup
branch
from
4b54944 to
25027fe
Compare
Member
Author
🤦 Thanks for catching that, I had actually forgotten to remove that line to enable the linter through golangci-lint. I updated the PR with it |
joamaki
approved these changes
Mar 12, 2026
Member
|
/test |
julianwiedmann
removed
the
sig/policy
Member
|
@cilium/ztunnel ping |
nddq
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
waitgroupmodernize analyzer globally and address the last remaining failures.Patch generated with
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -waitgroup ./...Followup to #42642