ipam: Move IPAM API rate-limit flags into the operator IPAM cell#44587
Merged
ipam: Move IPAM API rate-limit flags into the operator IPAM cell#44587
Conversation
4d6dbc4 to
2230273
Compare
Member
Author
|
/test |
2230273 to
3b156b9
Compare
Member
Author
|
/test |
`limit-ipam-api-burst` and `limit-ipam-api-qps` were registered in the global `InitGlobalFlags` and stored in `OperatorConfig`, but they are exclusively consumed by the cloud-provider IPAM allocators. Now that those allocators have proper hive cells, move the flags into the base IPAM cell config so they are owned and registered where they are used. Signed-off-by: Hadrien Patte <[email protected]>
3b156b9 to
1d2cc16
Compare
Member
Author
|
/test |
christarazi
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
limit-ipam-api-burstandlimit-ipam-api-qpswere registered in the globalInitGlobalFlagsand stored inOperatorConfig, but they are exclusively consumed by the cloud-provider IPAM allocators. Now that those allocators have proper hive cells, move the flags into the base IPAM cell config so they are owned and registered where they are used.