Skip to content

ipam: Move IPAM API rate-limit flags into the operator IPAM cell#44587

Merged
gandro merged 1 commit intomainfrom
pr/HadrienPatte/ipam-flags
Mar 3, 2026
Merged

ipam: Move IPAM API rate-limit flags into the operator IPAM cell#44587
gandro merged 1 commit intomainfrom
pr/HadrienPatte/ipam-flags

Conversation

@HadrienPatte
Copy link
Copy Markdown
Member

limit-ipam-api-burst and limit-ipam-api-qps were registered in the global InitGlobalFlags and stored in OperatorConfig, but they are exclusively consumed by the cloud-provider IPAM allocators. Now that those allocators have proper hive cells, move the flags into the base IPAM cell config so they are owned and registered where they are used.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 1, 2026
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/ipam-flags branch from 4d6dbc4 to 2230273 Compare March 1, 2026 19:01
@HadrienPatte
Copy link
Copy Markdown
Member Author

/test

@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/ipam-flags branch from 2230273 to 3b156b9 Compare March 1, 2026 20:18
@HadrienPatte
Copy link
Copy Markdown
Member Author

/test

@HadrienPatte HadrienPatte added the area/ipam IP address management, including cloud IPAM label Mar 1, 2026
`limit-ipam-api-burst` and `limit-ipam-api-qps` were registered in the
global `InitGlobalFlags` and stored in `OperatorConfig`, but they are
exclusively consumed by the cloud-provider IPAM allocators. Now that
those allocators have proper hive cells, move the flags into the base
IPAM cell config so they are owned and registered where they are used.

Signed-off-by: Hadrien Patte <[email protected]>
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/ipam-flags branch from 3b156b9 to 1d2cc16 Compare March 1, 2026 22:41
@HadrienPatte
Copy link
Copy Markdown
Member Author

/test

@HadrienPatte HadrienPatte marked this pull request as ready for review March 2, 2026 09:24
@HadrienPatte HadrienPatte requested review from a team as code owners March 2, 2026 09:24
@HadrienPatte HadrienPatte added the release-note/misc This PR makes changes that have no direct user impact. label Mar 2, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 2, 2026
@HadrienPatte HadrienPatte added kind/cleanup This includes no functional changes. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 2, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 2, 2026
Copy link
Copy Markdown
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thank you!

@gandro gandro added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit b9730e4 Mar 3, 2026
593 of 597 checks passed
@gandro gandro deleted the pr/HadrienPatte/ipam-flags branch March 3, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipam IP address management, including cloud IPAM kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants